CrosswalkModule::applySlowDownByOcclusion has a cyclomatic complexity of 12, threshold = 9

A Complex Method has a high cyclomatic complexity. The recommended threshold for the C++ language is a cyclomatic complexity lower than 9.

There are many reasons for Complex Method. Sometimes, another design approach is beneficial such as a) modeling state using an explicit state machine rather than conditionals, or b) using table lookup rather than long chains of logic. In other scenarios, the function can be split using EXTRACT FUNCTION. Just make sure you extract natural and cohesive functions. Complex Methods can also be addressed by identifying complex conditional expressions and then using the DECOMPOSE CONDITIONAL refactoring.

CrosswalkModule::applySlowDown has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function

A Bumpy Road is a function that contains multiple chunks of nested conditional logic inside the same function. The deeper the nesting and the more bumps, the lower the code health.

A bumpy code road represents a lack of encapsulation which becomes an obstacle to comprehension. In imperative languages there’s also an increased risk for feature entanglement, which leads to complex state management. CodeScene considers the following rules for the code health impact: 1) The deeper the nested conditional logic of each bump, the higher the tax on our working memory. 2) The more bumps inside a function, the more expensive it is to refactor as each bump represents a missing abstraction. 3) The larger each bump – that is, the more lines of code it spans – the harder it is to build up a mental model of the function. The nesting depth for what is considered a bump is levels of conditionals.

Bumpy Road implementations indicate a lack of encapsulation. Check out the detailed description of the Bumpy Road code health issue.

A Bumpy Road often suggests that the function/method does too many things. The first refactoring step is to identify the different possible responsibilities of the function. Consider extracting those responsibilities into smaller, cohesive, and well-named functions. The EXTRACT FUNCTION refactoring is the primary response.

CrosswalkModule::applySlowDownByOcclusion has a nested complexity depth of 4, threshold = 4

Deep nested logic means that you have control structures like if-statements or loops inside other control structures. Deep nested logic increases the cognitive load on the programmer reading the code. The human working memory has a maximum capacity of 3-4 items; beyond that threshold, we struggle with keeping things in our head. Consequently, deep nested logic has a strong correlation to defects and accounts for roughly 20% of all programming mistakes.

CodeScene measures the maximum nesting depth inside each function. The deeper the nesting, the lower the code health. The threshold for the C++ language is 4 levels of nesting.

Occassionally, it's possible to get rid of the nested logic by Replacing Conditionals with Guard Clauses.

Another viable strategy is to identify smaller building blocks inside the nested chunks of logic and extract those responsibilities into smaller, cohesive, and well-named functions. The EXTRACT FUNCTION refactoring explains the steps.

CrosswalkModule::checkStopForStuckVehicles has 5 arguments, threshold = 4

Functions with many arguments indicate either a) low cohesion where the function has too many responsibilities, or b) a missing abstraction that encapsulates those arguments.

The threshold for the C++ language is 4 function arguments.

Start by investigating the responsibilities of the function. Make sure it doesn't do too many things, in which case it should be split into smaller and more cohesive functions. Consider the refactoring INTRODUCE PARAMETER OBJECT to encapsulate arguments that refer to the same logical concept.

CrosswalkModule::checkStopForCrosswalkUsers decreases in cyclomatic complexity from 21 to 20, threshold = 9

CrosswalkModule::checkStopForStuckVehicles decreases in cyclomatic complexity from 19 to 18, threshold = 9

CrosswalkModule::modifyPathVelocity is no longer above the threshold for cyclomatic complexity

CrosswalkModule::applySafetySlowDownSpeed is no longer above the threshold for cyclomatic complexity

CrosswalkModule::modifyPathVelocity no longer has a complex conditional

CrosswalkModule::checkStopForCrosswalkUsers decreases from 5 to 4 logical blocks with deeply nested code, threshold is one single block per function

CrosswalkModule::applySafetySlowDownSpeed is no longer above the threshold for logical blocks with deeply nested code

The mean cyclomatic complexity decreases from 6.39 to 5.91, threshold = 4

CrosswalkModule::modifyPathVelocity is no longer above the threshold for nested complexity depth

WalkwayModule::modifyPathVelocity decreases in cyclomatic complexity from 12 to 11, threshold = 9