{"results":{"result":{"added-files":{"code-health":9.940721089724326,"old-code-health":0.0,"files":[{"file":"lib/features/manage_account/presentation/preferences/model/preference_option.dart","loc":77,"code-health":9.6882083290695},{"file":"lib/features/manage_account/presentation/preferences/model/preference_option_registry.dart","loc":8,"code-health":10.0},{"file":"lib/features/manage_account/presentation/preferences/model/preference_options.dart","loc":145,"code-health":10.0},{"file":"test/features/manage_account/presentation/preferences/preference_option_registry_test.dart","loc":175,"code-health":10.0}]},"external-review-url":"https://github.com/linagora/tmail-flutter/pull/4601","old-code-health":10.0,"modified-files":{"code-health":10.0,"old-code-health":10.0,"files":[{"file":"lib/features/manage_account/presentation/preferences/bindings/preferences_bindings.dart","loc":40,"old-loc":26,"code-health":10.0,"old-code-health":10.0},{"file":"lib/features/manage_account/presentation/preferences/preferences_controller.dart","loc":140,"old-loc":209,"code-health":10.0,"old-code-health":10.0}]},"removed-files":{"code-health":0.0,"old-code-health":0.0,"files":[]},"external-review-id":"4601","analysis-time":"2026-06-10T08:03:51Z","negative-impact-count":1,"suppressions":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"affected-hotspots":0,"commits":["47da63ef3955b910f58980e87baaf963cc48e82e"],"is-negative-review":true,"negative-findings":{"number-of-types":1,"number-of-files-touched":1,"findings":[{"method":"ServerPreferenceOption.toggle","why-it-occurs":"A complex conditional is an expression inside a branch such as an <code>if</code>-statmeent which consists of multiple, logical operations. Example: <code>if (x.started() && y.running())</code>.Complex conditionals make the code even harder to read, and contribute to the Complex Method code smell. Encapsulate them.","name":"Complex Conditional","file":"lib/features/manage_account/presentation/preferences/model/preference_option.dart","refactoring-examples":[{"diff":"diff --git a/complex_conditional.js b/complex_conditional.js\nindex c43da09584..94259ce874 100644\n--- a/complex_conditional.js\n+++ b/complex_conditional.js\n@@ -1,16 +1,34 @@\n function messageReceived(message, timeReceived) {\n-   // Ignore all messages which aren't from known customers:\n-   if (!message.sender &&\n-       customers.getId(message.name) == null) {\n+   // Refactoring #1: encapsulate the business rule in a\n+   // function. A clear name replaces the need for the comment:\n+   if (!knownCustomer(message)) {\n      log('spam received -- ignoring');\n      return;\n    }\n \n-  // Provide an auto-reply when outside business hours:\n-  if ((timeReceived.getHours() > 17) ||\n-      (timeReceived.getHours() < 8)) {\n+  // Refactoring #2: encapsulate the business rule.\n+  // Again, note how a clear function name replaces the\n+  // need for a code comment:\n+  if (outsideBusinessHours(timeReceived)) {\n     return autoReplyTo(message);\n   }\n \n   pingAgentFor(message);\n+}\n+\n+function outsideBusinessHours(timeReceived) {\n+  // Refactoring #3: replace magic numbers with\n+  // symbols that communicate with the code reader:\n+  const closingHour = 17;\n+  const openingHour = 8;\n+\n+  const hours = timeReceived.getHours();\n+\n+  // Refactoring #4: simple conditional rules can\n+  // be further clarified by introducing a variable:\n+  const afterClosing = hours > closingHour;\n+  const beforeOpening = hours < openingHour;\n+\n+  // Yeah -- look how clear the business rule is now!\n+  return afterClosing || beforeOpening;\n }\n\\ No newline at end of file\n","language":"dart","improvement-type":"Complex Conditional"}],"change-level":"warning","is-hotspot?":false,"line":107,"what-changed":"ServerPreferenceOption.toggle has 1 complex conditionals with 2 branches, threshold = 2","how-to-fix":"Apply the [DECOMPOSE CONDITIONAL](https://refactoring.com/catalog/decomposeConditional.html) refactoring so that the complex conditional is encapsulated in a separate function with a good name that captures the business rule. Optionally, for simple expressions, introduce a new variable which holds the result of the complex conditional.","change-type":"introduced"}]},"positive-impact-count":0,"repo":"tmail-flutter","code-health":9.958960754424533,"version":"3.0","authors":["Benoit TELLIER"],"directives":{"added":[],"removed":[]},"positive-findings":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"notices":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"external-review-provider":"GitHub"},"analysistime":"2026-06-10T08:03:50.000Z","project-name":"james-project","repository":"https://github.com/linagora/tmail-flutter.git"}}