{"results":{"result":{"added-files":{"code-health":0.0,"old-code-health":0.0,"files":[]},"external-review-url":"https://github.com/linagora/tmail-flutter/pull/4435","old-code-health":9.751159938372135,"modified-files":{"code-health":9.82221100480684,"old-code-health":9.751159938372135,"files":[{"file":"lib/features/mailbox/data/network/mailbox_isolate_worker.dart","loc":274,"old-loc":290,"code-health":9.387218218812514,"old-code-health":9.096655465156704},{"file":"lib/features/thread/data/network/thread_isolate_worker.dart","loc":164,"old-loc":163,"code-health":9.6882083290695,"old-code-health":9.6882083290695},{"file":"lib/main/bindings/network/network_bindings.dart","loc":139,"old-loc":141,"code-health":10.0,"old-code-health":10.0},{"file":"lib/main/bindings/network/network_isolate_binding.dart","loc":121,"old-loc":125,"code-health":10.0,"old-code-health":10.0},{"file":"lib/main/main_entry.dart","loc":30,"old-loc":32,"code-health":10.0,"old-code-health":10.0},{"file":"test/features/identity_creator/presentation/identity_creator_controller_test.dart","loc":333,"old-loc":336,"code-health":10.0,"old-code-health":10.0},{"file":"lib/features/mailbox/data/datasource_impl/mailbox_datasource_impl.dart","loc":171,"old-loc":170,"code-health":10.0,"old-code-health":10.0}]},"removed-files":{"code-health":0.0,"old-code-health":0.0,"files":[]},"external-review-id":"4435","analysis-time":"2026-04-07T03:27:07Z","negative-impact-count":0,"suppressions":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"affected-hotspots":0,"commits":["683314030e1d087e82e646ad1672961474af9ec8","e6fdce12d87868f0598c699e6772ff51d0a6baa0","9943d45fdc1cdad605306636b98f6bc0911e8aad"],"is-negative-review":false,"negative-findings":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"positive-impact-count":4,"repo":"tmail-flutter","code-health":9.82221100480684,"version":"3.0","authors":["Dang Dat"],"directives":{"added":[],"removed":[]},"positive-findings":{"number-of-types":2,"number-of-files-touched":2,"findings":[{"method":"MailboxIsolateWorker._handleMarkAsMailboxReadAction","why-it-occurs":"A complex conditional is an expression inside a branch such as an <code>if</code>-statmeent which consists of multiple, logical operations. Example: <code>if (x.started() && y.running())</code>.Complex conditionals make the code even harder to read, and contribute to the Complex Method code smell. Encapsulate them.","name":"Complex Conditional","file":"lib/features/mailbox/data/network/mailbox_isolate_worker.dart","change-level":"improvement","is-hotspot?":false,"line":122,"what-changed":"MailboxIsolateWorker._handleMarkAsMailboxReadAction no longer has a complex conditional","how-to-fix":"Apply the [DECOMPOSE CONDITIONAL](https://refactoring.com/catalog/decomposeConditional.html) refactoring so that the complex conditional is encapsulated in a separate function with a good name that captures the business rule. Optionally, for simple expressions, introduce a new variable which holds the result of the complex conditional.","change-type":"fixed"},{"method":"MailboxIsolateWorker._handleMarkAsMailboxReadActionOnWeb","why-it-occurs":"A complex conditional is an expression inside a branch such as an <code>if</code>-statmeent which consists of multiple, logical operations. Example: <code>if (x.started() && y.running())</code>.Complex conditionals make the code even harder to read, and contribute to the Complex Method code smell. Encapsulate them.","name":"Complex Conditional","file":"lib/features/mailbox/data/network/mailbox_isolate_worker.dart","change-level":"improvement","is-hotspot?":false,"line":186,"what-changed":"MailboxIsolateWorker._handleMarkAsMailboxReadActionOnWeb no longer has a complex conditional","how-to-fix":"Apply the [DECOMPOSE CONDITIONAL](https://refactoring.com/catalog/decomposeConditional.html) refactoring so that the complex conditional is encapsulated in a separate function with a good name that captures the business rule. Optionally, for simple expressions, introduce a new variable which holds the result of the complex conditional.","change-type":"fixed"},{"method":"MailboxIsolateWorker._handleMarkAsMailboxReadActionOnWeb","why-it-occurs":"Functions with many arguments indicate either a) low cohesion where the function has too many responsibilities, or b) a missing abstraction that encapsulates those arguments.\n\nThe threshold for the Dart language is 4 function arguments.","name":"Excess Number of Function Arguments","file":"lib/features/mailbox/data/network/mailbox_isolate_worker.dart","change-level":"improvement","is-hotspot?":false,"line":154,"what-changed":"MailboxIsolateWorker._handleMarkAsMailboxReadActionOnWeb is no longer above the threshold for number of arguments","how-to-fix":"Start by investigating the responsibilities of the function. Make sure it doesn't do too many things, in which case it should be split into smaller and more cohesive functions. Consider the refactoring [INTRODUCE PARAMETER OBJECT](https://refactoring.com/catalog/introduceParameterObject.html) to encapsulate arguments that refer to the same logical concept.","change-type":"fixed"},{"method":"ThreadIsolateWorker._emptyMailboxFolderOnWeb","why-it-occurs":"Functions with many arguments indicate either a) low cohesion where the function has too many responsibilities, or b) a missing abstraction that encapsulates those arguments.\n\nThe threshold for the Dart language is 4 function arguments.","name":"Excess Number of Function Arguments","file":"lib/features/thread/data/network/thread_isolate_worker.dart","change-level":"improvement","is-hotspot?":false,"line":131,"what-changed":"ThreadIsolateWorker._emptyMailboxFolderOnWeb is no longer above the threshold for number of arguments","how-to-fix":"Start by investigating the responsibilities of the function. Make sure it doesn't do too many things, in which case it should be split into smaller and more cohesive functions. Consider the refactoring [INTRODUCE PARAMETER OBJECT](https://refactoring.com/catalog/introduceParameterObject.html) to encapsulate arguments that refer to the same logical concept.","change-type":"fixed"}]},"notices":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"external-review-provider":"GitHub"},"analysistime":"2026-04-07T03:27:06.000Z","project-name":"james-project","repository":"https://github.com/linagora/tmail-flutter.git"}}