{"results":{"result":{"added-files":{"code-health":9.923920115154214,"old-code-health":0.0,"files":[{"file":"test/transforms/utest_interpolation.py","loc":72,"code-health":10.0},{"file":"test/quantities/utest_math_operations.py","loc":88,"code-health":10.0},{"file":"test/quantities/utest_operations.py","loc":52,"code-health":10.0},{"file":"test/quantities/utest_quantities.py","loc":102,"code-health":10.0},{"file":"test/quantities/utest_quantity_error.py","loc":112,"code-health":9.6882083290695},{"file":"test/quantities/utest_units.py","loc":33,"code-health":10.0}]},"external-review-url":"https://github.com/SasView/sasdata/pull/152","old-code-health":7.4274780286388955,"modified-files":{"code-health":7.4664335664928805,"old-code-health":7.4274780286388955,"files":[{"file":"sasdata/quantities/quantity.py","loc":966,"old-loc":972,"code-health":5.600973759801595,"old-code-health":5.600973759801595},{"file":"sasdata/trend.py","loc":63,"old-loc":63,"code-health":9.240656298427343,"old-code-health":9.240656298427343},{"file":"sasdata/data.py","loc":101,"old-loc":52,"code-health":9.6882083290695,"old-code-health":9.6882083290695},{"file":"test/utest_new_sasdata.py","loc":33,"old-loc":33,"code-health":10.0,"old-code-health":10.0},{"file":"sasdata/guess.py","loc":45,"old-loc":45,"code-health":10.0,"old-code-health":10.0},{"file":"sasdata/default_units.py","loc":21,"old-loc":21,"code-health":10.0,"old-code-health":10.0},{"file":"sasdata/temp_ascii_reader.py","loc":183,"old-loc":182,"code-health":9.387218218812514,"old-code-health":9.387218218812514},{"file":"test/utest_temp_ascii_reader.py","loc":130,"old-loc":130,"code-health":10.0,"old-code-health":10.0},{"file":"sasdata/transforms/rebinning.py","loc":157,"old-loc":157,"code-health":9.6882083290695,"old-code-health":9.6882083290695},{"file":"conftest.py","loc":8,"old-loc":8,"code-health":10.0,"old-code-health":10.0},{"file":"sasdata/ascii_reader_metadata.py","loc":115,"old-loc":115,"code-health":10.0,"old-code-health":10.0},{"file":"sasdata/temp_hdf5_reader.py","loc":258,"old-loc":271,"code-health":9.011465636836428,"old-code-health":9.011465636836428},{"file":"test/sasdataloader/utest_sasdataload.py","loc":87,"old-loc":65,"code-health":10.0,"old-code-health":10.0},{"file":"sasdata/metadata.py","loc":470,"old-loc":205,"code-health":9.6882083290695,"old-code-health":9.6882083290695},{"file":"sasdata/quantities/unit_parser.py","loc":163,"old-loc":153,"code-health":8.997354731618337,"old-code-health":8.997354731618337},{"file":"sasdata/quantities/units.py","loc":3458,"old-loc":3459,"code-health":8.429228015211383,"old-code-health":8.429228015211383},{"file":"test/utest_unit_parser.py","loc":59,"old-loc":61,"code-health":10.0,"old-code-health":10.0},{"file":"sasdata/quantities/_units_base.py","loc":275,"old-loc":276,"code-health":8.695838958325648,"old-code-health":8.695838958325648},{"file":"sasdata/temp_xml_reader.py","loc":286,"old-loc":287,"code-health":8.564024942980211,"old-code-health":8.564024942980211},{"file":"sasdata/quantities/_build_tables.py","loc":316,"old-loc":316,"code-health":10.0,"old-code-health":10.0},{"file":"sasdata/quantities/accessors.py","loc":9283,"old-loc":9283,"code-health":7.080928795405863,"old-code-health":7.080928795405863},{"file":"sasdata/temp_sesans_reader.py","loc":166,"old-loc":166,"code-health":8.95517096544394,"old-code-health":8.95517096544394},{"file":"test/sasdataloader/utest_new_sesans.py","loc":93,"old-loc":101,"code-health":9.6882083290695,"old-code-health":9.6882083290695},{"file":"sasdata/quantities/numerical_encoding.py","loc":48,"old-loc":48,"code-health":9.6882083290695,"old-code-health":9.6882083290695},{"file":"sasdata/slicing/meshes/meshmerge.py","loc":79,"old-loc":79,"code-health":10.0,"old-code-health":10.0},{"file":"sasdata/model_requirements.py","loc":409,"old-loc":408,"code-health":8.88925181964737,"old-code-health":8.88925181964737},{"file":"sasdata/dataloader/filereader.py","loc":437,"old-loc":442,"code-health":6.964144570857635,"old-code-health":6.964144570857635},{"file":"sasdata/dataloader/readers/anton_paar_saxs_reader.py","loc":150,"old-loc":158,"code-health":8.492359985901361,"old-code-health":8.492359985901361},{"file":"sasdata/dataloader/readers/ascii_reader.py","loc":124,"old-loc":122,"code-health":8.564024942980211,"old-code-health":8.564024942980211},{"file":"sasdata/dataloader/readers/cansas_reader_HDF5.py","loc":648,"old-loc":658,"code-health":4.776599831222441,"old-code-health":4.776599831222441},{"file":"sasdata/dataloader/readers/danse_reader.py","loc":145,"old-loc":144,"code-health":8.988900121251596,"old-code-health":8.988900121251596},{"file":"sasdata/dataloader/readers/red2d_reader.py","loc":195,"old-loc":192,"code-health":8.505579854866642,"old-code-health":8.505579854866642},{"file":"sasdata/dataloader/readers/sesans_reader.py","loc":134,"old-loc":134,"code-health":9.3931346077612,"old-code-health":9.3931346077612},{"file":"sasdata/dataloader/readers/tiff_reader.py","loc":73,"old-loc":73,"code-health":9.6882083290695,"old-code-health":9.6882083290695},{"file":"sasdata/quantities/_accessor_base.py","loc":108,"old-loc":108,"code-health":8.783158986130568,"old-code-health":8.783158986130568},{"file":"sasdata/slicing/transforms.py","loc":31,"old-loc":31,"code-health":10.0,"old-code-health":10.0},{"file":"test/slicers/utest_point_assignment.py","loc":2,"old-loc":2,"code-health":10.0,"old-code-health":10.0},{"file":"test/utest_sasdata.py","loc":82,"old-loc":82,"code-health":8.679575849015766,"old-code-health":8.679575849015766},{"file":"test/utest_trend.py","loc":61,"old-loc":61,"code-health":10.0,"old-code-health":10.0},{"file":"sasdata/dataloader/readers/cansas_reader.py","loc":1225,"old-loc":1234,"code-health":3.7304106053804875,"old-code-health":3.7304106053804875},{"file":"sasdata/file_converter/ascii2d_loader.py","loc":105,"old-loc":105,"code-health":9.287275302261085,"old-code-health":9.287275302261085}]},"removed-files":{"code-health":0.0,"old-code-health":0.0,"files":[]},"external-review-id":"152","analysis-time":"2025-08-12T10:24:53Z","negative-impact-count":0,"suppressions":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"affected-hotspots":11,"commits":["a1c9693eeb8e412905b4766e96aa4047648d4f2a","8b8ed5fd17ba0213886e2bb7b968c85fd573a62b","f8b7fef09b2771133b381d8035beb404c127a6c1","7430b527d686d1160b69fb3d17f45318600da9ea","289c4620d0407176600f295a99cd4419608405c1","6adacdd3970ef27ed373533045ebc786137d2397","07db1770bdb0a97aebc6a809aa45af466fbdb84d","6e03e35e007ee4ea560063fbf984c02241b4ea37","a233b32ba1464e77e074fbabd772552eb77040f1","5c60a84515dce319b9d29fe4c95104b8d27110b2","997fe385a741412daa37bc97dad24c533ac63964","8376806ddc562958dd1e08135f223ae539285656","f0f7d044ad6eb3d7af31998c8c0d0a8b002be82b","9653f5db12cbc0107e46005cb760f35aae840bb6","105e33bb16356a4853008a1fa8cf7038df80e234","8468fa4330541df83d8e815e72d8ea35a790e0ae","1ac6855e8bd13a7d372b48491d2e7a9571d35955","82a2ee5c87e1d2ad0a59e4d6ad7cfb32a3b37226","bf3da4845a54e8d1e821133d40984e80b30f8ef7","418da9c56ad1b86cd572366ce32ef500e70c7616","36a76a1079406c8cdd9567e2dd2773ec0fa989a7","1253acc086419912238d88c311d625570bf4d8bd","682c7fb89a3b1d4c5228c9110faf4efa68ca0859","4f26560d3d84e86699be82c8232038e37f399e18","0ea1cddfa6bb69bfca04824ee6833f76284ef353","004cc663b69e08026b0a6f8b97ed9192e4b56aaf","647b242d34789575aea43e256c1a5a0cac3602a6","bcfb6e8da9b81397efa8a156b98c8f78b6aa3564","dd15ff2be40424e70e3e05c9be12ffcbb05dc516","6e989f81195a53dd92ec997d319bc30e0435a4a1","44acb80ea06c9da904b15f272ecfd74a19016a8d","18f42e679b51b32b76c30b8d72c599f2d110a15b","e5e0f2893c4eecdb52d7f3a1d735198b8b82a8f1","75a66084b16e88392872a3e2e0e5d3bb7a02a656","bacc68ae2c3d4c425baf6e321508792ccc51b6af","94cc4066e60d9f03c31485eccf6a825f84fdf332","7b04ce6517cd32a7dc3a5b5b70c23b99a86efdb7","e53becbce602eed4cfd46140caa62493fd5ad7b9","f3e457a07f7fb7465f1ad63507e85d078e6727b9","1f739174d53725d226b1ac5b563ba605f4ad9ee8","821ceaa395c5f667a82334b949b40bd2d158bacf","8dccd79049cbfba40e543683b6d342d68607c1fb","d76e61b66a725fac3c3edbeb00bd129cdaaba8b8","097863fe7635f7db2a7b923bfebf86a4b2b8bda4","9adb7167e090f5b016927745d96163af35ca5913","692a77570e9ece7ccbbee4ec4739ec9d59037616","cd91c64a0b4df89a155779a3f8d8956b772b0531","7cafe5e8e2461413e1d8f229a2fb88e9fec949ef","edb50c102323bd877e7ac775ace75ed4b44a0331","6b8504bedb72385455246cfde0cd41180abfdb00","99ef0a23e9e46e58d7fcf26f54832b9ffdb8658a","a54409d044f0fa1998a01198ff03508bab05d876","b8ea91343a6ad1ac692bf6e4c0b1917f241a0639","5917ad5fa762a9d4cf2055b46b06203b10d10af9","84eacd4a121d900afa98c7337aaadb4591f8b026","e91381e72f480733209209ebe7bc8d75a770d80c","8a27a352bbf2de57f1390eb8f4b05f13d841a65e","e3c0931b8178e79b9acc6c792dab7a53976ce398","ad3702d245b0e947e593d2e72abb1bc6e97481a2","89857b5ccd48a03f239f1a7e42a0d470c4928777","e179a8afe98c50ff4eddb5369515b71815917fdd","0b6ad9671e286dfca5dc1cb716ac8e15973769ab","b49b9635cf3672e5f7cb496ff266c6457f0aab15","14becaf05282c91a7ce2d4b23595e37ee6713ed8","c8199acdf055c8780217602a783cf5b3278f4fc1","70c7b57b3bf067ad37f28c6ea74c7063027fa48d","1e38eb984047c0fe16606c3cf2266c450f8b1b18","d811c74800d86c43cbe066a9f88c705e30849eb0","4e8d1e2cabf897dce34572ac52b67f65b7ed8b4a","3650799238ae1ebce5239255ca85013dee73251b","fb1f8323ace46a9fbaf46c6329de99ce4bdf9038","9bffdeab1a830713b9f1f5f98fc07c7edecbf8ae","f569ebb31641c8c2a2ba1efda9ae81b6e5866d71","73a5d529fee74a6316b236d5322454cda22f0d48","232e95a13e43a03d6f459b3e881eaa6296f666ca","ff6c04797af0e2bae1aded1e9b16e7e6a2bc3f5f","8376b2509980a7adcaa5a2e0228eb9c62502646a","21af33dc9c6b77409279c6e1be778ded1762f2ff","769acfa3aaf7e06f547611438e8dd7eb1b521c06","bb1801ed4d9f161b8cda8f74184d357598a02249","8468a2aa5b19a81d2bf13c6d874bd4e499562dc3","37c52dde17a385f4c0570b5fb428b87b934d7096","e1bf63cd1f2c5d7c6b492fbaa87e0deada233990","622b192e8ede388b180be0352e9deb740c57948a","1507fcc5ae873946289b056eeb0e029b94e7f504","3f098696adb0569a90bd5af516ac1976f38016e4","6b9d67c16bb60c7bd8aef49827ed1d1849760342","200c0c8a87947c5e70a20bcdb7ca15d1edebcb22","2c950a82a402c909e778bf8d3bd79fc32820c0c1","a049c0164cfb77ba8914cf8ac6b3c7cb094b4cd7","4b4f195b682b6062447264015d2fbb8dd83bce65","fb5b2b1155502f42852ef7e77e78c70239be3853","22b8056d7e7c7e428297896098aa2e5ca430e1fa","aca995c8a412379536a02d9465775cd67cd9858e","bddf195eb76d080984e0beaf6d217a89a8d41bee","2b19d9761c650debe09d08e8330f4e07a87b71e7","c873839f7a2b45fb287deab66db3ed74206213df","9e6636f9224bcfea9c810416a993796b4716cbb1","116644079fa8f23dac233724c9a0d487303d053d","4735381647acbe3d0a2fd7bf23fb68133be3519e","4a31fed40dec9daffebad7311fae1cf69fbf07fe","04c2a580e35168e709b08034508b6761cf785f9b","4f04412fb8b3fecc03b78bd93ece4c5f8570ce70","0cb5af665955e76ee25dd600859758a11e508d47","7f13429d3bf8dbc912cd260c5c921edeccb979d9","c0a3fb4f51f49c88a325ae736ee7e4147cf59c36","11a444fab75219590a06478c685b4e0c652ac32a","47693ecb78252fbe68fc30953517ed2af2eaa65a","a2484afb2d2886e87fe775a100f77d4a318480a3","bd0d70b4a83684645d72f588bac96c9ab5326973","e48e1df38b7391b44869924faac7bb86e8571620","12723c5ef98c5d41d205886c57a76f571d38fe23","4881def39de63cc5980cda493ea7c8124d7a5160","938fb8bfbc72c3d8151e150664920904bc69ab90","98270d8cd32a7e44f74cf88f477343c756c2f48a","e853519de43463514085ecb04381d1233df9e28b","d71c5cbd5bbbe78c05560c5bd2afd2a3e25b1888","de5a31c8fc692e7e6e767ddff1c572cf1a34db83","446750a5f2f402d4059ebf991ce122331204f61b","0628b765c91c908b033fb736cd17b17f617d2aec","f936d2405cacffbd2ba0c60b3a40b3b9109920e7","2cc0e650234e74533fb734ed7d6e185561150101","0f0f443ae7b9a34af0f552cef6eac6a71aef6448","71948a5236a6e4924ac8289567c8598bc1718b93","de470add09d459c49f5aaebd735758e1d3f5df5e","56b0b5028e731596fd7a0099066c57f844a6eda4","667acdb55a9d3bd93a1881e6423795a0a4818886","2b04abbd968579bc402b1055b45bf503be558fa8","93aaece8ff273bd542e9400e4453b5e46d97ce8a","d9c43f8df3a0bc37ee2db0e12cfab4da72d6d520","ce9ddfb42a794b6db6ce335dc0870d6198574081","eb10aed97f3b969b7502314e1f46170cce727f80","378639367e94b50ec6f0cf902ed6d13349a93374","3d0496ea4c8d0063acf58ead92ab0379c63098fc","b1b99c150db8ee79dc9babc3cf0d55f80f51f287","8451a8e4d0ca2de9c567996e0f486a27f58ee5ac","584c6c292fdcd04c5a62cf1e84968b8cf34af957","1aa27cd717f1e6ee820cad9b5bb0a69539c84658","72c51ad42174904ec4309243dd517f80aadcb659","4e428db320af159f9e48cadcd6d56fe1397f6c91","45cf7f22f4b93863f84095ee4abe37a539fbeea3","6b8adf4923e5697192fb14873f94867473a1b57b","1e512910ed35079fdb6942b0fea2ae08d9a350d9","40a4d54f14bcb8307491cb3c161d52979db73ee7","b97c6e4ea12813a9af5c6edd0c312769b4b21716","d096aa90d4d0e493dea3fa10bdd8fb123e2b9dd0","f46cdf1c22e7fc29ee9ead306f1e3d905912ab83","5a1d3e2d69870daf6ca3f8fd62e38499e7b3f822","a6f2b1c87140faa0fb5755bcdf85e30bfafc5f13","b57e011d0cd712617538d5c53344270140972a2e","ad74973995fc606299da19c2abf44966af60086b","729894e1d9d580266f355d584b3e2a44faed29c8","03f4a507111ce03ebe733f3c37ecee633a7a5664","b10a60ff3c5045df59c4e8f69a493510e4401bbf","7f64eab1c767f0df670ffe2a540f26e9574e0b12","17f67c7ef6b4529bce5d4b999952da899172f32c","fd1e019dcfce47546c17d624041cff1ade5d596c","88a88a8977d111ac81e59937bc0e8486f7d3e36f","7b20fed06a18e423b1c8d9d0fa19928f08075f5b","92b18a2b04e45a780677b5b633d84c1af6eb4aac","2ba70cbda2c4a28abfbed9fcdfc04ef2e5421269","29884ecbd538f1d06328158fef33d4b0ba59b211","6d506ae0b7b89c6be311c8069bed5e353f5f94b3","70a734b094e7501a4ea9758d03687939c46a07a6","23e2688fa3fa4c12f06d8b436af08fa9c37b9481","c73b6b9b5a40a298c367e4f4d975e555001aa4ab","0b64135c27a005de2a2b3d578f2e8310418f204e","8a676385105792e26587dc18029b1793ff64c8cd","ccf340a9391f96229a6c04d5f2b7e100ea7d2ccd","e0fa047850d3b5f71aba3b6199b4babec9765eaa","6c70ec3e53a5d1241a1089ca16c309a0ce9fdef2","248d632c945612681a9ac42a4fe82b42a54097e8","f90636f37f554d3a9460336d8fba3d6243b39f13","36d8ed668ca2a9720bebcd64a2e1d6c8f6228603","2f50b987b9572c137dba54484b5f6fbd08fd6828","f1c7cf67ddef1a100a67afa833d3c14abc91df9e","cfb830cf9415bd9d4b11a7d5032560cdab691d46","fbb80b50fe32b2d17bb93b81adcde9755d7c5ff0","2bcb5d96d70edb16e06381cb5c182626e4a1d6cd","3ae5d9bb209f5bdbf5e19da38466ca9234993bad","55a19d83c40ac11c41e9ad3382a738f9be08b2aa","14187de7bc97dfdcfc918e5b752cd2dcee507273","e8aac4e4a5be8007a892877b9d7b1b7cb16acf36","bbc5fcb8d8019ec15ca377875e4d464f22df8ed7","3f9ff9f706970e4a049c25786208c7c4c2a0f0dc","469ec03a5cb2df2876285af50a156b70aa4b7619","dd0192f9c2f42094ac792f37b5bc6a5875d5b3ba","d5ef68ea8f1eb01429860fb6521664371baa6bcb","5a5ba0d39828a9c6ff2d90cc15e47905ba1ead98","009fc2240b98db3a4f5f32de8bd6acb456d9ca94","56dc4f2bbc766cff4a1854624397b9146cd7b0e8","c7c9414d9e769da524dcd2148249c44da5948400","7b5e83a4edf963a833a7ae6fde7c1d371f824019","6870d75442ab36cfcfe46e38c51439d437a45e00","50b2b269036690209582eba597f72b35ede9df58","8f52345d3642754e3c06b00cc97eba29b451f19f","c2429487cac2277ec278a614b791093dcacb0828","bde17386ee03187a460f775031120c3d917b3f2d","f70dd333406abcffb599e9b00a49a3e83a5a2610","ecb25c68e88f1691a9b7c7d22a979ec020f8d06d","f885fc73e91ef9647b151b6909d06db90091b1fa","7c17464cbcaec2d82babd9c7a30c94a4ef52ab5f","8c33099c92433e69ccd856914d359dfbbb86c1d1","24f61cbb90225c7bab98a395bb524883578e9085","e92a569fccc30ef2ea2d43791894213155f95838","d478640dbba4488759871d381428738c969bbcb8","82bbda77d0d06edca5efa96a5c0bc7a18c2822cd","6a2aadb792c510154dd477c38b416a8d3121f073","43d2de60691d970d586157589e5f68095a8be66d","e5aa7c9c40e1988e942bb9f0284f44a561c88edc","4022d9e18e6140902130d4efd2f4053c7d6e8d65","bf98d30a6068172dc9a7d62117dccbb0dbe2747a","669a66fa3e75f8891e22ee125e0e67d36e7705db","6e4a47d30a0bdb853b95d5d77c4f97e42777acb0","73eedec00f82944ff141c032c338db04d45d5960","29a8f1094bc41ff43e91946b0b1c480d1d047d09","652e5180add3c9468015e8da97bb1d333daa1d75","03136ceb646d9cb19072617794b42cda7b7e9fcc","f298babf239b165f60c7ab445fd5f7058cd8f5b8","de977f0c45b95e81b0620f6d09912c948ded2dbc","7adadb3a08f2dd0842b0d55977ab94a959bbecca","5a5911f49b83f57d961bc1d35ff2d618ccb9e3cf","f3e310c73e50157f94bbb3336439b3f48f68a64f","524838a7939074366d7d43ead9c4bdb4a0d6bb2d","61f699d8cee007f3cc1fbd5665c5bb1e1b794909","b7fbe4666de9adeaf98cf5d564446f3d3017162b","bbcef626cecd11f6d407b68e5a17d2e33e65376b","4b395816f1c999d9543a1cc34bc35bfc30ee2be7","232c2faafe0d1d87756c4cc8982d089ad9169a81","a8acced47777713712ce4a38ea136a2f083b7551","e88b6fdbc07346dc2e6aa3ff0b5342e0ecfccc29","cdf7f2ec907f11e6d5db5a1f28c33bdacec2c83d","78c82b9e42f2c3acc6c51d4b8c93add62c47b6c1","d716fbe2132ee1aaa285e3e0fb10ed9be1ebdf40","04bec784d48f18612e6c5f161ba2cd4b30e22158","30ea7b8de5e9e0a045133e34b4a9e68a8fbd71af","4dc11c763c31a2992461975a1d4a0dc745a4b54f","159fb38bfc13a33f5b68e8c719cc5d1f214abe0b","0948ddbf5862d8cb079794e6a6ebc7cd3d447382","83dae00a079391ebc543b02146ae4b61af833f6a","2564420711f100c8a0efb4e6acd1bfd751fadfa4","1b8df0713dd251e255fd098f0221f5c523af1319","f37e75d6a9bad6637190c888a90363989337ce77","28ba9ca81b5108ff1f04ff767a93aa9ec6f02b91","8217c4e215e2a3315b6765167e8b4cf64c709bc9","3106dd7286e1a02660436c1a03c945a895b33059","e55d87ee4b134e99441580474a5b90c7d68d0698","836bbc20ace9436bc71fe345c20873b284bed683","93c64ce240869a70c78d90760573e7ab15034d16","2f06cbf1a7a57556405d81dfe9955708da58c028"],"is-negative-review":false,"negative-findings":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"positive-impact-count":3,"repo":"sasdata","code-health":7.519512778098714,"version":"3.0","authors":["James Crake-Merani","Adam Washington","PaulSharp"],"directives":{"added":[],"removed":[]},"positive-findings":{"number-of-types":3,"number-of-files-touched":3,"findings":[{"name":"Lines of Code in a Single File","file":"sasdata/quantities/quantity.py","change-type":"improved","change-level":"improvement","is-hotspot?":false,"why-it-occurs":"This module has 874 lines of code (comments stripped away). This puts the module at risk of evolving into a Brain Class. Brain Classes are problematic since changes become more complex over time, harder to test, and challenging to refactor. Act now to prevent future maintenance issues.","how-to-fix":"Look for opportunities to modularize the design. This is done by identifying groups of functions that represent different responsibilities and/or operate on different data. Once you have identified the different responsibilities, then use refactorings like [EXTRACT CLASS](https://refactoring.com/catalog/extractClass.html).","what-changed":"The lines of code decreases from 880 to 874, improve code health by reducing it to 600"},{"name":"Overall Code Complexity","file":"sasdata/quantities/unit_parser.py","change-type":"improved","change-level":"improvement","is-hotspot?":false,"why-it-occurs":"Overall Code Complexity is measured by the mean cyclomatic complexity across all functions in the file. The lower the number, the better.\n\nCyclomatic complexity is a function level metric that measures the number of logical branches (if-else, loops, etc.). Cyclomatic complexity is a rough complexity measure, but useful as a way of estimating the minimum number of unit tests you would need. As such, prefer functions with low cyclomatic complexity (2-3 branches).","how-to-fix":"You address the overall cyclomatic complexity by a) modularizing the code, and b) abstract away the complexity. Let's look at some examples:\n\nModularizing the Code: Do an X-Ray and inspect the local hotspots. Are there any complex conditional expressions? If yes, then do a [DECOMPOSE CONDITIONAL](https://refactoring.com/catalog/decomposeConditional.html) refactoring. Extract the conditional logic into a separate function and put a good name on that function. This clarifies the intent and makes the original function easier to read. Repeat until all complex conditional expressions have been simplified.\n\n","what-changed":"The mean cyclomatic complexity decreases from 4.82 to 4.67, threshold = 4"},{"name":"Lines of Declarations in a Single File","file":"sasdata/quantities/units.py","change-type":"improved","change-level":"improvement","is-hotspot?":false,"what-changed":"The lines of data declarations decreases from 3242 to 3241, threshold = 1500"}]},"notices":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"external-review-provider":"GitHub"},"analysistime":"2025-08-12T10:24:52.000Z","project-name":"sasdata","repository":"https://github.com/SasView/sasdata.git"}}