{"results":{"result":{"added-files":{"code-health":0.0,"old-code-health":0.0,"files":[]},"external-review-url":"https://github.com/umbraco/Umbraco-CMS/pull/20041","old-code-health":9.5707669185404,"modified-files":{"code-health":9.5707669185404,"old-code-health":9.5707669185404,"files":[{"file":"src/Umbraco.Web.UI.Client/devops/icons/index.js","loc":176,"old-loc":174,"code-health":9.5707669185404,"old-code-health":9.5707669185404}]},"removed-files":{"code-health":0.0,"old-code-health":0.0,"files":[]},"external-review-id":"20041","analysis-time":"2025-09-01T06:50:42Z","negative-impact-count":1,"suppressions":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"affected-hotspots":0,"commits":["301bbd7e6848c7a591d8a9d36e006584061066e9","a2f94f7fc01be28d3750068b822dd06a2291bedc","97213fcd3e825c7f2034fbc0801aabdc0218b09b"],"is-negative-review":true,"negative-findings":{"number-of-types":1,"number-of-files-touched":1,"findings":[{"method":"collectDictionaryIcons","why-it-occurs":"Overly long functions make the code harder to read. The recommended maximum function length for the JavaScript language is 70 lines of code. Severity: Brain Method - Complex Method - Long Method.","name":"Large Method","file":"src/Umbraco.Web.UI.Client/devops/icons/index.js","refactoring-examples":null,"change-level":"warning","is-hotspot?":false,"line":33,"what-changed":"collectDictionaryIcons has 77 lines, threshold = 70","how-to-fix":"We recommend to be careful here -- just splitting long functions don't necessarily make the code easier to read. Instead, look for natural chunks inside the functions that expresses a specific task or concern. Often, such concerns are indicated by a Code Comment followed by an if-statement. Use the [EXTRACT FUNCTION](https://refactoring.com/catalog/extractFunction.html) refactoring to encapsulate that concern.","change-type":"introduced"}]},"positive-impact-count":1,"repo":"Umbraco-CMS","code-health":9.5707669185404,"version":"3.0","authors":["Jacob Overgaard"],"directives":{"added":[],"removed":[]},"positive-findings":{"number-of-types":1,"number-of-files-touched":1,"findings":[{"method":"collectDictionaryIcons","why-it-occurs":"A Complex Method has a high cyclomatic complexity. The recommended threshold for the JavaScript language is a cyclomatic complexity lower than 9.","name":"Complex Method","file":"src/Umbraco.Web.UI.Client/devops/icons/index.js","change-level":"improvement","is-hotspot?":false,"line":32,"what-changed":"collectDictionaryIcons is no longer above the threshold for cyclomatic complexity","how-to-fix":"There are many reasons for Complex Method. Sometimes, another design approach is beneficial such as a) modeling state using an explicit state machine rather than conditionals, or b) using table lookup rather than long chains of logic. In other scenarios, the function can be split using [EXTRACT FUNCTION](https://refactoring.com/catalog/extractFunction.html). Just make sure you extract natural and cohesive functions. Complex Methods can also be addressed by identifying complex conditional expressions and then using the [DECOMPOSE CONDITIONAL](https://refactoring.com/catalog/decomposeConditional.html) refactoring.","change-type":"fixed"}]},"notices":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"external-review-provider":"GitHub"},"analysistime":"2025-09-01T06:50:42.000Z","project-name":"Umbraco-CMS","repository":"https://github.com/umbraco/Umbraco-CMS.git"}}