{"results":{"result":{"added-files":{"code-health":10.0,"old-code-health":0.0,"files":[{"file":"tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/RenderingContent/RenderingContentWithCulturePublishStatus.spec.ts","loc":58,"code-health":10.0}]},"external-review-url":"https://github.com/umbraco/Umbraco-CMS/pull/23047","old-code-health":6.805411302357391,"modified-files":{"code-health":6.801933681105255,"old-code-health":6.805411302357391,"files":[{"file":"tests/Umbraco.Tests.AcceptanceTest/lib/helpers/DocumentApiHelper.ts","loc":1614,"old-loc":1585,"code-health":6.210772551850412,"old-code-health":6.210772551850412},{"file":"tests/Umbraco.Tests.AcceptanceTest/lib/helpers/DocumentTypeApiHelper.ts","loc":1056,"old-loc":1037,"code-health":6.792138886046333,"old-code-health":6.792138886046333},{"file":"tests/Umbraco.Tests.AcceptanceTest/lib/helpers/TemplateApiHelper.ts","loc":489,"old-loc":489,"code-health":8.545379580978913,"old-code-health":8.545379580978913},{"file":"tests/Umbraco.Tests.AcceptanceTest/lib/helpers/ContentRenderUiHelper.ts","loc":35,"old-loc":33,"code-health":10.0,"old-code-health":10.0}]},"removed-files":{"code-health":0.0,"old-code-health":0.0,"files":[]},"external-review-id":"23047","analysis-time":"2026-06-03T19:21:25Z","negative-impact-count":0,"suppressions":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"affected-hotspots":0,"commits":["81bd4aefbcd38dd715eaeb3b5076762dfc653837","a22f7280e48d08f859936541ba6b1b96a2193da9","d3e723cc0a0e640133dd735130ba04130a3d398e","5cc7aaed679a015dd59267d07a78c497aed3fc88","d184c7c722ec17bbeac5af6b9ad1c1e1d6f70656","37953f9bbab9abd516c9f19439220354c1f2c8db"],"is-negative-review":false,"negative-findings":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"positive-impact-count":4,"repo":"Umbraco-CMS","code-health":6.858971764283575,"version":"3.0","authors":["Andreas Zerbst"],"directives":{"added":[],"removed":[]},"positive-findings":{"number-of-types":3,"number-of-files-touched":2,"findings":[{"name":"Missing Arguments Abstractions","file":"tests/Umbraco.Tests.AcceptanceTest/lib/helpers/DocumentApiHelper.ts","change-type":"improved","change-level":"improvement","is-hotspot?":false,"why-it-occurs":"This code health issue is measured as the average number of function arguments across the whole file. A function with many arguments can be simplified either by a) splitting the function if it has too many responsibilities, or b) by introducing an abstraction (class, record, struct, etc.) which encapsulates the arguments. ","how-to-fix":"Start by investigating the responsibilities of the function. Make sure it doesn't do too many things, in which case it should be split into smaller and more cohesive functions. Consider the refactoring [INTRODUCE PARAMETER OBJECT](https://refactoring.com/catalog/introduceParameterObject.html) to encapsulate arguments that refer to the same logical concept.","what-changed":"The average number of function arguments decreases from 4.19 to 4.13, threshold = 4.00"},{"name":"Primitive Obsession","file":"tests/Umbraco.Tests.AcceptanceTest/lib/helpers/DocumentApiHelper.ts","change-type":"improved","change-level":"improvement","is-hotspot?":false,"why-it-occurs":"Code that uses a high degree of built-in, primitives such as integers, strings, floats, lacks a domain language that encapsulates the validation and semantics of function arguments. Primitive Obsession has several consequences: 1) In a statically typed language, the compiler will detect less erroneous assignments. 2) Security impact since the possible value range of a variable/argument isn't retricted.\n\nIn this module, 97 % of all functions have primitive types as arguments.","how-to-fix":"Primitive Obsession indicates a missing domain language. Introduce data types that encapsulate the details and constraints of your domain. For example, instead of `int userId`, consider `User clicked`.","what-changed":"The ratio of primitive types in function arguments decreases from 97.16% to 96.97%, threshold = 30.0%"},{"name":"String Heavy Function Arguments","file":"tests/Umbraco.Tests.AcceptanceTest/lib/helpers/DocumentApiHelper.ts","change-type":"improved","change-level":"improvement","is-hotspot?":false,"why-it-occurs":"String is a generic type that fail to capture the constraints of the domain object it represents. In this module, 95 % of all function arguments are string types.","how-to-fix":"Heavy string usage indicates a missing domain language. Introduce data types that encapsulate the semantics. For example, a user_name is better represented as a constrained User type rather than a pure string, which could be anything.","what-changed":"The ratio of strings in function arguments decreases from 95.17% to 95.04%, threshold = 39.0%"},{"name":"String Heavy Function Arguments","file":"tests/Umbraco.Tests.AcceptanceTest/lib/helpers/DocumentTypeApiHelper.ts","change-type":"improved","change-level":"improvement","is-hotspot?":false,"why-it-occurs":"String is a generic type that fail to capture the constraints of the domain object it represents. In this module, 87 % of all function arguments are string types.","how-to-fix":"Heavy string usage indicates a missing domain language. Introduce data types that encapsulate the semantics. For example, a user_name is better represented as a constrained User type rather than a pure string, which could be anything.","what-changed":"The ratio of strings in function arguments decreases from 86.93% to 86.70%, threshold = 39.0%"}]},"notices":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"external-review-provider":"GitHub"},"analysistime":"2026-06-03T19:21:24.000Z","project-name":"Umbraco-CMS","repository":"https://github.com/umbraco/Umbraco-CMS.git"}}