{"results":{"result":{"added-files":{"code-health":0.0,"old-code-health":0.0,"files":[]},"external-review-url":"https://github.com/BrighterCommand/Brighter/pull/4116","old-code-health":7.625720302106259,"modified-files":{"code-health":7.637604823782288,"old-code-health":7.625720302106259,"files":[{"file":"src/Paramore.Brighter/InMemoryBox.cs","loc":104,"old-loc":99,"code-health":10.0,"old-code-health":10.0},{"file":"src/Paramore.Brighter/InMemoryInbox.cs","loc":183,"old-loc":148,"code-health":8.413528317237752,"old-code-health":8.545379580978913},{"file":"src/Paramore.Brighter/InMemoryOutbox.cs","loc":408,"old-loc":384,"code-health":7.788037646779413,"old-code-health":7.788037646779413},{"file":"src/Paramore.Brighter/OutboxProducerMediator.cs","loc":872,"old-loc":869,"code-health":6.966247769888114,"old-code-health":6.966247769888114},{"file":"src/Paramore.Brighter.Extensions.DependencyInjection/ServiceCollectionExtensions.cs","loc":609,"old-loc":596,"code-health":7.624891450768529,"old-code-health":7.624891450768529},{"file":"src/Paramore.Brighter/ProducersConfiguration.cs","loc":61,"old-loc":59,"code-health":10.0,"old-code-health":10.0}]},"removed-files":{"code-health":0.0,"old-code-health":0.0,"files":[]},"external-review-id":"4116","analysis-time":"2026-05-06T21:41:15Z","negative-impact-count":1,"suppressions":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"affected-hotspots":2,"commits":["01f980394b4deee78cca649afd982c01e5ee7457","c946209726b872b335b7b6cf5eac9aa9bbe1bd65","59198dc621e8328a96aa4c916445e8f933edb313","673625509143b1a9cb9a780351ff9126cda70c66","b7ae36f553395e0800a53ad120745ead3560c354","8edf71b89b6f4fb07b15b79ce73f989090b6585d","d3190977402fa213830179ef9ca94b8d74f89b73","2bd6791e9600009f68f97141d50105db5dc41136","ff29abeebc677ed958cb505041f9d59125e34b03","bbe9e1bc6c25eac24346c1678557e318a52157b7","cdcdfc28e8b1bcd33f50f08a631896d2f1e2bfd6","fe4c1ed814fb36dcbcd2ede1a18220792e176ab7","cd96ea3a2bdb7089e88cb2dc272097f8b19d4e31","e368a3ceeb6fd86dc6c3fc05987104afdcc65c4b","b25b5fc39235ef1112ec422446a89a63c5608816","f6c67fbbdc8f96e9c90ec6c5ebbb8e0dba1c9559","e04a2889fd934c33d5ecc16799c69796db507ae9","81b08a37ec8aef7707445a85f2db775416f16d71","7c91900f6e8dbb0b61e37101ebe708d6ff1eb092","c6e107cabed30618e66f5a2adff61496a97533d6","b45c7137955171cd60257bccfaed73f7731e3d59","408c08c9d06d608546f15b5cf0e595a7fcbe69ac"],"is-negative-review":true,"negative-findings":{"number-of-types":1,"number-of-files-touched":1,"findings":[{"method":"Add","why-it-occurs":"A Bumpy Road is a function that contains multiple chunks of nested conditional logic inside the same function. The deeper the nesting and the more bumps, the lower the code health.\n\nA bumpy code road represents a lack of encapsulation which becomes an obstacle to comprehension. In imperative languages there’s also an increased risk for feature entanglement, which leads to complex state management. CodeScene considers the following rules for the code health impact: 1) The deeper the nested conditional logic of each bump, the higher the tax on our working memory. 2) The more bumps inside a function, the more expensive it is to refactor as each bump represents a missing abstraction. 3) The larger each bump – that is, the more lines of code it spans – the harder it is to build up a mental model of the function. The nesting depth for what is considered a bump is  levels of conditionals.","name":"Bumpy Road Ahead","file":"src/Paramore.Brighter/InMemoryInbox.cs","refactoring-examples":null,"change-level":"warning","is-hotspot?":false,"line":128,"what-changed":"Add has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function","how-to-fix":"Bumpy Road implementations indicate a lack of encapsulation. Check out the detailed description of the [Bumpy Road code health issue](https://codescene.com/blog/bumpy-road-code-complexity-in-context/).\n\nA Bumpy Road often suggests that the function/method does too many things. The first refactoring step is to identify the different possible responsibilities of the function. Consider extracting those responsibilities into smaller, cohesive, and well-named functions. The [EXTRACT FUNCTION](https://refactoring.com/catalog/extractFunction.html) refactoring is the primary response.","change-type":"introduced"}]},"positive-impact-count":3,"repo":"Brighter","code-health":7.637604823782288,"version":"3.0","authors":["Ian Cooper"],"directives":{"added":[],"removed":[]},"positive-findings":{"number-of-types":3,"number-of-files-touched":2,"findings":[{"name":"Primitive Obsession","file":"src/Paramore.Brighter/InMemoryInbox.cs","change-type":"improved","change-level":"improvement","is-hotspot?":false,"why-it-occurs":"Code that uses a high degree of built-in, primitives such as integers, strings, floats, lacks a domain language that encapsulates the validation and semantics of function arguments. Primitive Obsession has several consequences: 1) In a statically typed language, the compiler will detect less erroneous assignments. 2) Security impact since the possible value range of a variable/argument isn't retricted.\n\nIn this module, 62 % of all functions have primitive types as arguments.","how-to-fix":"Primitive Obsession indicates a missing domain language. Introduce data types that encapsulate the details and constraints of your domain. For example, instead of `int userId`, consider `User clicked`.","what-changed":"The ratio of primitive types in function arguments decreases from 62.86% to 62.16%, threshold = 30.0%"},{"name":"String Heavy Function Arguments","file":"src/Paramore.Brighter/InMemoryInbox.cs","change-type":"improved","change-level":"improvement","is-hotspot?":false,"why-it-occurs":"String is a generic type that fail to capture the constraints of the domain object it represents. In this module, 43 % of all function arguments are string types.","how-to-fix":"Heavy string usage indicates a missing domain language. Introduce data types that encapsulate the semantics. For example, a user_name is better represented as a constrained User type rather than a pure string, which could be anything.","what-changed":"The ratio of strings in function arguments decreases from 45.71% to 43.24%, threshold = 39.0%"},{"name":"Missing Arguments Abstractions","file":"src/Paramore.Brighter/InMemoryOutbox.cs","change-type":"improved","change-level":"improvement","is-hotspot?":false,"why-it-occurs":"This code health issue is measured as the average number of function arguments across the whole file. A function with many arguments can be simplified either by a) splitting the function if it has too many responsibilities, or b) by introducing an abstraction (class, record, struct, etc.) which encapsulates the arguments. ","how-to-fix":"Start by investigating the responsibilities of the function. Make sure it doesn't do too many things, in which case it should be split into smaller and more cohesive functions. Consider the refactoring [INTRODUCE PARAMETER OBJECT](https://refactoring.com/catalog/introduceParameterObject.html) to encapsulate arguments that refer to the same logical concept.","what-changed":"The average number of function arguments decreases from 4.57 to 4.26, threshold = 4.00"}]},"notices":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"external-review-provider":"GitHub"},"analysistime":"2026-05-06T21:41:14.000Z","project-name":"Brighter","repository":"https://github.com/BrighterCommand/Brighter.git"}}