AvoidanceModule::plan already has high cyclomatic complexity, and now it increases in Lines of Code from 104 to 106

A Complex Method has a high cyclomatic complexity. The recommended threshold for the C++ language is a cyclomatic complexity lower than 9.

There are many reasons for Complex Method. Sometimes, another design approach is beneficial such as a) modeling state using an explicit state machine rather than conditionals, or b) using table lookup rather than long chains of logic. In other scenarios, the function can be split using EXTRACT FUNCTION. Just make sure you extract natural and cohesive functions. Complex Methods can also be addressed by identifying complex conditional expressions and then using the DECOMPOSE CONDITIONAL refactoring.

TurnSignalDecider::getBehaviorTurnSignalInfo has a cyclomatic complexity of 23, threshold = 9

A Complex Method has a high cyclomatic complexity. The recommended threshold for the C++ language is a cyclomatic complexity lower than 9.

There are many reasons for Complex Method. Sometimes, another design approach is beneficial such as a) modeling state using an explicit state machine rather than conditionals, or b) using table lookup rather than long chains of logic. In other scenarios, the function can be split using EXTRACT FUNCTION. Just make sure you extract natural and cohesive functions. Complex Methods can also be addressed by identifying complex conditional expressions and then using the DECOMPOSE CONDITIONAL refactoring.

The lines of code increases from 1192 to 1194, improve code health by reducing it to 1000

This module has 1194 lines of code (comments stripped away). This puts the module at risk of evolving into a Brain Class. Brain Classes are problematic since changes become more complex over time, harder to test, and challenging to refactor. Act now to prevent future maintenance issues.

Look for opportunities to modularize the design. This is done by identifying groups of functions that represent different responsibilities and/or operate on different data. Once you have identified the different responsibilities, then use refactorings like EXTRACT CLASS.

The mean cyclomatic complexity increases from 7.25 to 8.46, threshold = 4

Overall Code Complexity is measured by the mean cyclomatic complexity across all functions in the file. The lower the number, the better.

Cyclomatic complexity is a function level metric that measures the number of logical branches (if-else, loops, etc.). Cyclomatic complexity is a rough complexity measure, but useful as a way of estimating the minimum number of unit tests you would need. As such, prefer functions with low cyclomatic complexity (2-3 branches).

You address the overall cyclomatic complexity by a) modularizing the code, and b) abstract away the complexity. Let's look at some examples:

Modularizing the Code: Do an X-Ray and inspect the local hotspots. Are there any complex conditional expressions? If yes, then do a DECOMPOSE CONDITIONAL refactoring. Extract the conditional logic into a separate function and put a good name on that function. This clarifies the intent and makes the original function easier to read. Repeat until all complex conditional expressions have been simplified.

The lines of code increases from 1653 to 1657, improve code health by reducing it to 1000

This module has 1657 lines of code (comments stripped away). This puts the module at risk of evolving into a Brain Class. Brain Classes are problematic since changes become more complex over time, harder to test, and challenging to refactor. Act now to prevent future maintenance issues.

Look for opportunities to modularize the design. This is done by identifying groups of functions that represent different responsibilities and/or operate on different data. Once you have identified the different responsibilities, then use refactorings like EXTRACT CLASS.

The lines of code increases from 1717 to 1738, improve code health by reducing it to 1000

This module has 1738 lines of code (comments stripped away). This puts the module at risk of evolving into a Brain Class. Brain Classes are problematic since changes become more complex over time, harder to test, and challenging to refactor. Act now to prevent future maintenance issues.

Look for opportunities to modularize the design. This is done by identifying groups of functions that represent different responsibilities and/or operate on different data. Once you have identified the different responsibilities, then use refactorings like EXTRACT CLASS.

The mean cyclomatic complexity increases from 5.06 to 5.09, threshold = 4

Overall Code Complexity is measured by the mean cyclomatic complexity across all functions in the file. The lower the number, the better.

Cyclomatic complexity is a function level metric that measures the number of logical branches (if-else, loops, etc.). Cyclomatic complexity is a rough complexity measure, but useful as a way of estimating the minimum number of unit tests you would need. As such, prefer functions with low cyclomatic complexity (2-3 branches).

You address the overall cyclomatic complexity by a) modularizing the code, and b) abstract away the complexity. Let's look at some examples:

Modularizing the Code: Do an X-Ray and inspect the local hotspots. Are there any complex conditional expressions? If yes, then do a DECOMPOSE CONDITIONAL refactoring. Extract the conditional logic into a separate function and put a good name on that function. This clarifies the intent and makes the original function easier to read. Repeat until all complex conditional expressions have been simplified.

The lines of code decreases from 1895 to 1711, improve code health by reducing it to 1000

existShiftSideLane is no longer above the threshold for cyclomatic complexity

calcTurnSignalInfo is no longer above the threshold for cyclomatic complexity

existShiftSideLane is no longer above the threshold for logical blocks with deeply nested code

The mean cyclomatic complexity decreases from 4.96 to 4.76, threshold = 4

existShiftSideLane is no longer above the threshold for number of arguments

isNearEndOfShift is no longer above the threshold for number of arguments

calcTurnSignalInfo is no longer above the threshold for number of arguments

The number of functions in this module is no longer above the threshold

The lines of code decreases from 1369 to 1340, improve code health by reducing it to 1000

StartPlannerModule::calcTurnSignalInfo is no longer above the threshold for cyclomatic complexity

StartPlannerModule::calcTurnSignalInfo no longer has a complex conditional

StartPlannerModule::calcTurnSignalInfo is no longer above the threshold for logical blocks with deeply nested code