{"results":{"result":{"added-files":{"code-health":0.0,"old-code-health":0.0,"files":[]},"external-review-url":"https://github.com/grumpycoders/pcsx-redux/pull/1965","old-code-health":7.8771391269514615,"modified-files":{"code-health":7.874735038560967,"old-code-health":7.8771391269514615,"files":[{"file":"tools/vscode-extension/tools.js","loc":696,"old-loc":696,"code-health":6.51978787144334,"old-code-health":6.51978787144334},{"file":"tools/macos-mips/mipsel-none-elf-binutils.rb","loc":51,"old-loc":20,"code-health":10.0,"old-code-health":10.0},{"file":"tools/vscode-extension/scripts/mipsel-none-elf-binutils.rb","loc":51,"old-loc":20,"code-health":10.0,"old-code-health":10.0},{"file":"tools/macos-mips/mipsel-none-elf-gcc.rb","loc":76,"old-loc":49,"code-health":10.0,"old-code-health":10.0},{"file":"tools/macos-mips/mipsel-none-elf-gdb.rb","loc":22,"old-loc":22,"code-health":10.0,"old-code-health":10.0},{"file":"tools/vscode-extension/scripts/mipsel-none-elf-gcc.rb","loc":76,"old-loc":49,"code-health":10.0,"old-code-health":10.0},{"file":"tools/vscode-extension/scripts/mipsel-none-elf-gdb.rb","loc":22,"old-loc":22,"code-health":10.0,"old-code-health":10.0},{"file":"src/mips/openbios/card/device.c","loc":547,"old-loc":547,"code-health":5.832076823135224,"old-code-health":5.832076823135224},{"file":"src/mips/openbios/cdrom/cdrom.c","loc":140,"old-loc":140,"code-health":9.387218218812514,"old-code-health":9.387218218812514},{"file":"src/mips/openbios/tty/tty.c","loc":161,"old-loc":161,"code-health":9.002996108761327,"old-code-health":9.002996108761327},{"file":"src/mips/psyqo/src/xprintf.c","loc":595,"old-loc":605,"code-health":9.611962998402053,"old-code-health":10.0}]},"removed-files":{"code-health":0.0,"old-code-health":0.0,"files":[]},"external-review-id":"1965","analysis-time":"2025-09-01T19:00:23Z","negative-impact-count":2,"suppressions":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"affected-hotspots":0,"commits":["a759cb841c56d7a976dd6b9254fe330aee315c59","d911c2b106de6978015f2d6682813509eb12b135","5cb9084d55493c97486886377fe89e578ca25db4","27e6fab9ae690411ecf287892fe91204ea1fa6e4","00bd1db0d9f22ba3ec3e0e4693a93bd7d6aeec10","d56b30e33caee35bb844c8263c21337f157fd15e","c319254ebcd744fb0d85afb80f50ceb0d3b0d539","909eb220bcf4f2e3bb02bde4fdb09d0e330f2522","a7035f322fcfe445a5de6e359113b57fca291823","d6e15260754569570956bcc58de7a275c94004dd"],"is-negative-review":true,"negative-findings":{"number-of-types":2,"number-of-files-touched":1,"findings":[{"method":"sout","why-it-occurs":"A Bumpy Road is a function that contains multiple chunks of nested conditional logic inside the same function. The deeper the nesting and the more bumps, the lower the code health.\n\nA bumpy code road represents a lack of encapsulation which becomes an obstacle to comprehension. In imperative languages there’s also an increased risk for feature entanglement, which leads to complex state management. CodeScene considers the following rules for the code health impact: 1) The deeper the nested conditional logic of each bump, the higher the tax on our working memory. 2) The more bumps inside a function, the more expensive it is to refactor as each bump represents a missing abstraction. 3) The larger each bump – that is, the more lines of code it spans – the harder it is to build up a mental model of the function. The nesting depth for what is considered a bump is  levels of conditionals.","name":"Bumpy Road Ahead","file":"src/mips/psyqo/src/xprintf.c","refactoring-examples":null,"change-level":"warning","is-hotspot?":false,"line":703,"what-changed":"sout has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function","how-to-fix":"Bumpy Road implementations indicate a lack of encapsulation. Check out the detailed description of the [Bumpy Road code health issue](https://codescene.com/blog/bumpy-road-code-complexity-in-context/).\n\nA Bumpy Road often suggests that the function/method does too many things. The first refactoring step is to identify the different possible responsibilities of the function. Consider extracting those responsibilities into smaller, cohesive, and well-named functions. The [EXTRACT FUNCTION](https://refactoring.com/catalog/extractFunction.html) refactoring is the primary response.","change-type":"introduced"},{"why-it-occurs":"String is a generic type that fail to capture the constraints of the domain object it represents. In this module, 50 % of all function arguments are string types.","name":"String Heavy Function Arguments","file":"src/mips/psyqo/src/xprintf.c","refactoring-examples":null,"change-level":"warning","is-hotspot?":false,"what-changed":"In this module, 50.0% of all arguments to its 7 functions are strings. The threshold for string arguments is 39.0%","how-to-fix":"Heavy string usage indicates a missing domain language. Introduce data types that encapsulate the semantics. For example, a user_name is better represented as a constrained User type rather than a pure string, which could be anything.","change-type":"introduced"}]},"positive-impact-count":0,"repo":"pcsx-redux","code-health":7.874735038560967,"version":"3.0","authors":["Nicolas \"Pixel\" Noble"],"directives":{"added":[],"removed":[]},"positive-findings":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"notices":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"external-review-provider":"GitHub"},"analysistime":"2025-09-01T19:00:23.000Z","project-name":"pcsx-redux","repository":"https://github.com/grumpycoders/pcsx-redux.git"}}