{"results":{"result":{"added-files":{"code-health":9.6882083290695,"old-code-health":0.0,"files":[{"file":"satpy/tests/modifier_tests/test_atmosphere.py","loc":200,"code-health":9.6882083290695}]},"external-review-url":"https://github.com/pytroll/satpy/pull/3371","old-code-health":9.096655465156704,"modified-files":{"code-health":9.387218218812514,"old-code-health":9.096655465156704,"files":[{"file":"satpy/tests/test_modifiers.py","loc":338,"old-loc":493,"code-health":9.387218218812514,"old-code-health":9.096655465156704}]},"removed-files":{"code-health":0.0,"old-code-health":0.0,"files":[]},"external-review-id":"3371","analysis-time":"2026-04-08T18:02:39Z","negative-impact-count":1,"suppressions":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"affected-hotspots":0,"commits":["1fa02a6aa95b97bb7559770282b9a3765f020538","bf75088bbd938fe32a6d85a87d3131f7e092f5fb"],"is-negative-review":true,"negative-findings":{"number-of-types":1,"number-of-files-touched":1,"findings":[{"method":"TestPSPRayleighReflectance.test_rayleigh_corrector","why-it-occurs":"Functions with many arguments indicate either a) low cohesion where the function has too many responsibilities, or b) a missing abstraction that encapsulates those arguments.\n\nThe threshold for the Python language is 4 function arguments.","name":"Excess Number of Function Arguments","file":"satpy/tests/modifier_tests/test_atmosphere.py","refactoring-examples":null,"change-level":"warning","is-hotspot?":false,"line":105,"what-changed":"TestPSPRayleighReflectance.test_rayleigh_corrector has 9 arguments, max arguments = 4","how-to-fix":"Start by investigating the responsibilities of the function. Make sure it doesn't do too many things, in which case it should be split into smaller and more cohesive functions. Consider the refactoring [INTRODUCE PARAMETER OBJECT](https://refactoring.com/catalog/introduceParameterObject.html) to encapsulate arguments that refer to the same logical concept.","change-type":"introduced"}]},"positive-impact-count":1,"repo":"satpy","code-health":9.499110453108793,"version":"3.0","authors":["Gerrit Holl"],"directives":{"added":[],"removed":[]},"positive-findings":{"number-of-types":1,"number-of-files-touched":1,"findings":[{"method":"TestPSPRayleighReflectance.test_rayleigh_corrector","why-it-occurs":"Functions with many arguments indicate either a) low cohesion where the function has too many responsibilities, or b) a missing abstraction that encapsulates those arguments.\n\nThe threshold for the Python language is 4 function arguments.","name":"Excess Number of Function Arguments","file":"satpy/tests/test_modifiers.py","change-level":"improvement","is-hotspot?":false,"line":504,"what-changed":"TestPSPRayleighReflectance.test_rayleigh_corrector is no longer above the threshold for number of arguments","how-to-fix":"Start by investigating the responsibilities of the function. Make sure it doesn't do too many things, in which case it should be split into smaller and more cohesive functions. Consider the refactoring [INTRODUCE PARAMETER OBJECT](https://refactoring.com/catalog/introduceParameterObject.html) to encapsulate arguments that refer to the same logical concept.","change-type":"fixed"}]},"notices":{"number-of-types":0,"number-of-files-touched":0,"findings":[]},"external-review-provider":"GitHub"},"analysistime":"2026-04-08T18:02:38.000Z","project-name":"satpy","repository":"https://github.com/pytroll/satpy.git"}}